antonipp commented on code in PR #514:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/514#discussion_r1094261486
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java:
##########
@@ -340,6 +341,11 @@ protected Configuration build() {
// Set cluster config
effectiveConfig.setString(KubernetesConfigOptions.NAMESPACE,
namespace);
effectiveConfig.setString(KubernetesConfigOptions.CLUSTER_ID,
clusterId);
+
+ if (FlinkUtils.isZookeeperHAActivated(effectiveConfig)) {
+ effectiveConfig.setString(HighAvailabilityOptions.HA_CLUSTER_ID,
clusterId);
Review Comment:
Unfortunately I couldn't implement this logic because the value of
`HA_CLUSTER_ID` is overridden way deep in Flink's code 😞
For Standalone applications it's overridden here in the Operator's code, so
it's easy to change:
https://github.com/apache/flink-kubernetes-operator/blob/bf3e1d44506809fda9ec1ef75308496c7202bbff/flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/standalone/KubernetesStandaloneClusterDescriptor.java#L140
However, for Native applications, it's overridden in Flink's code:
https://github.com/apache/flink/blob/ab3eb40d920fa609f49164a0bbb5fcbb3004a808/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java#L255
Since this requires changing logic in the main Flink project, I didn't touch
the `HA_CLUSTER_ID` value in this Operator PR. It's probably worth doing as a
separate ticket later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
