Fanoid commented on code in PR #199: URL: https://github.com/apache/flink-ml/pull/199#discussion_r1090567035
########## flink-ml-servable-core/pom.xml: ########## @@ -0,0 +1,74 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-ml-parent</artifactId> + <version>2.2-SNAPSHOT</version> + </parent> + + <artifactId>flink-ml-servable-core</artifactId> + <name>Flink ML : Servable : Core</name> + + <dependencies> + <dependency> Review Comment: Hi, @lindong28 , I understand your point. For the issues mentioned above, I agree that we could figure out solutions sooner or later. My concern is the compatibility issue that will be introduced in the future when resolving above issues. Assuming current PR is merged (after reviewed), people may start using `flink-ml-servable-core`. End-users are free to use `TypeInformation`s like `DenseVectorTypeInfo`, since they are public and necessary if they use `DenseVector` in Flink jobs. However, to achieve our goal, we have to eliminate `flink-core` from `flink-ml-servable-core` dependencies in future changes. The elimination is likely to lead to moving `DenseVectorTypeInfo` out from `flink-ml-servable-core`. As a consequence, this could breaks end-users' usages described above during this time. Hope this can clarify my concern 😊. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
