Fanoid commented on code in PR #199: URL: https://github.com/apache/flink-ml/pull/199#discussion_r1091386638
########## flink-ml-servable-core/pom.xml: ########## @@ -0,0 +1,74 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-ml-parent</artifactId> + <version>2.2-SNAPSHOT</version> + </parent> + + <artifactId>flink-ml-servable-core</artifactId> + <name>Flink ML : Servable : Core</name> + + <dependencies> + <dependency> Review Comment: > > In both situations, after directly depending on flink-ml-servable-core, users may import DenseVectorTypeInfo in their code > > Hmm... can you explain why user would import DenseVectorTypeInfo in their code? I think users would only need to use DenseVector to use Flink ML, right? Also note that DenseVectorTypeInfo is not marked `@PublicEvolving`. > > BTW, I guess we need to mark classes such as `DenseVector` and `Vector` as `public` For example, the prediction `Row` of `LogisticRegressionModel` contains a field of type `DenseVector` (storing probability of being positive and negative). It is possible that users call `flatMap(...).returns(Types.ROW(..., DenseVectorTypeInfo.INSTANCE, ...)` in their code to do some post-processing on the prediction results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
