zhuzhurk commented on code in PR #21787:
URL: https://github.com/apache/flink/pull/21787#discussion_r1090578267


##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -551,91 +551,6 @@ public enum SchedulerType {
                                             
code(SchedulerType.AdaptiveBatch.name()))

Review Comment:
   This config option is left behind.



##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -551,91 +551,6 @@ public enum SchedulerType {
                                             
code(SchedulerType.AdaptiveBatch.name()))
                                     .build());
 
-    @Documentation.Section({

Review Comment:
   `JobManagerOptions` is `@PublicEnvlving` so we should only deprecate but not 
remove these options.
   We can exclude them from the documentation with 
`@Documentation.ExcludeFromDocumentation`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to