zhuzhurk commented on code in PR #21787:
URL: https://github.com/apache/flink/pull/21787#discussion_r1091418181
##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -535,10 +535,13 @@ public enum SchedulerType {
.withDescription(
"Controls whether partitions should already be
released during the job execution.");
+ /** @deprecated Use {@link
BatchExecutionOptions#ADAPTIVE_AUTO_PARALLELISM_MIN_PARALLELISM}. */
@Documentation.Section({
Documentation.Sections.EXPERT_SCHEDULING,
Documentation.Sections.ALL_JOB_MANAGER
})
+ @Documentation.ExcludeFromDocumentation("Hidden for deprecated")
+ @Deprecated
public static final ConfigOption<Integer>
ADAPTIVE_BATCH_SCHEDULER_MIN_PARALLELISM =
Review Comment:
The `@Documentation.Section` should be removed.
##########
flink-core/src/main/java/org/apache/flink/configuration/BatchExecutionOptions.java:
##########
@@ -32,4 +37,112 @@ public class BatchExecutionOptions {
.defaultValue(true)
.withDescription(
"If true, Flink will automatically decide the
parallelism of operators in batch jobs.");
+
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<Integer>
ADAPTIVE_AUTO_PARALLELISM_MIN_PARALLELISM =
+ key("execution.batch.adaptive.auto-parallelism.min-parallelism")
+ .intType()
+ .defaultValue(1)
+
.withDeprecatedKeys("jobmanager.adaptive-batch-scheduler.min-parallelism")
+ .withDescription(
+ Description.builder()
+ .text(
+ "The lower bound of allowed
parallelism to set adaptively if %s has been set to %s. "
+ + "Currently, this option
should be configured as a power of 2, "
+ + "otherwise it will also
be rounded up to a power of 2 automatically.",
+ code(SCHEDULER.key()),
+ code(
+
JobManagerOptions.SchedulerType.AdaptiveBatch
+ .name()))
+ .build());
+
+ @Documentation.Section({Documentation.Sections.EXPERT_SCHEDULING})
+ public static final ConfigOption<Integer>
ADAPTIVE_AUTO_PARALLELISM_MAX_PARALLELISM =
+ key("execution.batch.adaptive.auto-parallelism.max-parallelism")
+ .intType()
+ .defaultValue(128)
+
.withDeprecatedKeys("jobmanager.adaptive-batch-scheduler.max-parallelism")
+ .withDescription(
+ Description.builder()
+ .text(
+ "The upper bound of allowed
parallelism to set adaptively if %s has been set to %s. "
+ + "Currently, this option
should be configured as a power of 2, "
Review Comment:
The description is outdated. It was changed in a previous commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
