[ 
https://issues.apache.org/jira/browse/FLINK-30405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682503#comment-17682503
 ] 

Zsombor Chikan commented on FLINK-30405:
----------------------------------------

for some reason the `CommonStatus` class does not read by the 
`CrdReferenceDoclet` class, however the `CommonStatus` class also within the 
`org.apache.flink.kubernetes.operator.api.status` package, so the `run()` 
method of the `CrdReferenceDoclet` class has to be read this as well, based on 
this code snippet:

```
printStream.println("## Status");
var status =
sortedByName(
environment.getIncludedElements().stream()
.filter(e -> e.toString().startsWith(STATUS_PACKAGE_PREFIX))
.collect(Collectors.toSet()));
handleAbstractClass(status, environment.getTypeUtils());
se.show(status);
```

but the reference.md file does not include the `CommonStatus` class at the end 
of the build, and neither the `flinkdeployments.flink.apache.org-v1.yml` file 
and I think this is the reason why the `kubectl get flinkdeployments` command 
does not return a value for the `RESOURCE LIFECYCLE STATE` column as it can be 
seen below:

!image-2023-01-31-12-15-18-295.png|width=466,height=48!

> Add ResourceLifecycleStatus to CommonStatus and printer column 
> ---------------------------------------------------------------
>
>                 Key: FLINK-30405
>                 URL: https://issues.apache.org/jira/browse/FLINK-30405
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kubernetes Operator
>            Reporter: Gyula Fora
>            Assignee: Zsombor Chikan
>            Priority: Major
>              Labels: starter
>             Fix For: kubernetes-operator-1.4.0
>
>         Attachments: image-2023-01-31-12-15-18-295.png
>
>
> The CommonStatus api already contains a getter for the ResourceLifecycleState 
> of a Flink resource.
> We should remove the JsonIgnore annotation to expose this in the status. 
> We should also expose this as a printer column instread of the reconciliation 
> status that is used currently.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to