[
https://issues.apache.org/jira/browse/FLINK-30405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682537#comment-17682537
]
Márton Balassi commented on FLINK-30405:
----------------------------------------
[~zch93] you are mixing 2 generator utilities:
1. The CrDReferenceDoclet is used to generate the documentation for the CRD
yaml file. This was useful for a previous ticket, but it is not in play here.
2. There is the CRDGenerator that we use from Fabric8, such that it can
generate the CRD yaml file based on the Java classes that we define to describe
our Flink applications:
{noformat}
2023-01-31 04:04:18,325 i.f.c.g.CRDGenerator [INFO ] [.] Generating
'flinksessionjobs.flink.apache.org' version 'v1beta1' with
org.apache.flink.kubernetes.operator.api.FlinkSessionJob (spec:
org.apache.flink.kubernetes.operator.api.spec.FlinkSessionJobSpec / status
org.apache.flink.kubernetes.operator.api.status.FlinkSessionJobStatus)...
2023-01-31 04:04:19,402 i.f.c.g.CRDGenerator [INFO ] [.] Generating
'flinkdeployments.flink.apache.org' version 'v1beta1' with
org.apache.flink.kubernetes.operator.api.FlinkDeployment (spec:
org.apache.flink.kubernetes.operator.api.spec.FlinkDeploymentSpec / status
org.apache.flink.kubernetes.operator.api.status.FlinkDeploymentStatus)...
{noformat}
This utilitiy comes from:
{noformat}
<dependency>
<groupId>io.fabric8</groupId>
<artifactId>kubernetes-client</artifactId>
<version>${fabric8.version}</version>
</dependency>
{noformat}
Ideally you only need to replace this line with a printer column annotation:
https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/CommonStatus.java#L53
And rerun the maven build to trigger the generator.
> Add ResourceLifecycleStatus to CommonStatus and printer column
> ---------------------------------------------------------------
>
> Key: FLINK-30405
> URL: https://issues.apache.org/jira/browse/FLINK-30405
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
> Reporter: Gyula Fora
> Assignee: Zsombor Chikan
> Priority: Major
> Labels: starter
> Fix For: kubernetes-operator-1.4.0
>
> Attachments: image-2023-01-31-12-15-18-295.png
>
>
> The CommonStatus api already contains a getter for the ResourceLifecycleState
> of a Flink resource.
> We should remove the JsonIgnore annotation to expose this in the status.
> We should also expose this as a printer column instread of the reconciliation
> status that is used currently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
