zhangjun0x01 commented on code in PR #471:
URL: https://github.com/apache/flink-table-store/pull/471#discussion_r1095310375
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/FileSystemCatalog.java:
##########
@@ -162,6 +162,11 @@ public void createTable(Identifier identifier,
UpdateSchema table, boolean ignor
uncheck(() -> new SchemaManager(path).commitNewVersion(table));
}
+ @Override
+ public void renameTable(Identifier fromTable, Identifier toTable, boolean
ignoreIfNotExists) {
+ throw new UnsupportedOperationException("Cannot rename FileSystem
catalog tables");
Review Comment:
My initial idea is that some file systems (such as s3) do not support rename
operation, so I did not add the file system rename operation.
I see that the latest
interface(`org.apache.flink.table.store.fs.FileIO#rename`) adds the rename
operation, so I also add the file system catalog rename operation. If some
filesystem does not support the rename operation, rename table will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
