fredia commented on code in PR #63:
URL: https://github.com/apache/flink-benchmarks/pull/63#discussion_r1095310674
##########
regression_report.py:
##########
@@ -131,8 +133,12 @@ def checkBenchmark(args, exe, benchmark):
median_trend = 0
if median != 0:
median_trend = recent_median * 100 / median - 100
- if median_trend < args.medianTrendThreshold:
- # regression detected, print warning
+
+ # regression detected, print warning
+ if median_trend < args.medianTrendThreshold and lessIsbBetter is False:
+ print "<%s|%s> median=%s recent_median=%s" % (urlToBenchmark,
benchmark, median, recent_median)
+
+ if median_trend > (-1 * args.medianTrendThreshold) and lessIsbBetter:
Review Comment:
👍Good point, extracted it into `isThresholdReached`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
