[ 
https://issues.apache.org/jira/browse/FLINK-4717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564964#comment-15564964
 ] 

ASF GitHub Bot commented on FLINK-4717:
---------------------------------------

Github user uce commented on the issue:

    https://github.com/apache/flink/pull/2609
  
    To help review, the main change is in `JobManager` and `CliFrontend`. Some 
questions there may be:
    - Should we keep the behaviour that the job is not cancelled if the 
savepoint fails? My reasoning for this was that the user might otherwise 
accidentally loose state when cancelling the job.
    - Does the way that the cancellation is specified on the CLI make sense? 
Should we keep the `-s` option or add another proper command like `bin/flink 
cancel-with-savepoint`?
    



> Naive version of atomic stop signal with savepoint
> --------------------------------------------------
>
>                 Key: FLINK-4717
>                 URL: https://issues.apache.org/jira/browse/FLINK-4717
>             Project: Flink
>          Issue Type: New Feature
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.2.0
>            Reporter: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> As a first step towards atomic stopping with savepoints we should implement a 
> cancel command which prior to cancelling takes a savepoint. Additionally, it 
> should turn off the periodic checkpointing so that there won't be checkpoints 
> executed between the savepoint and the cancel command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to