ASF GitHub Bot commented on FLINK-4717:

Github user uce commented on a diff in the pull request:

    --- Diff: docs/setup/cli.md ---
    @@ -113,6 +113,10 @@ The command line can be used to
             ./bin/flink cancel <jobID>
    +-   Cancel a job with a savepoint:
    +        ./bin/flink cancel -s [targetDirectory] <jobID>
    --- End diff --
    We could also change the savepoint trigger command to `savepoint -t 
[targetDir] <jobID>`.
    Or we could allow `cancel <jobID> [targetDirectory]` in addition to the 
`-s` option variant, but that might be slightly confusing, too. We need the 
`-s` option without an argument for cancel with savepoint to the default target.
    What do you think?

> Naive version of atomic stop signal with savepoint
> --------------------------------------------------
>                 Key: FLINK-4717
>                 URL: https://issues.apache.org/jira/browse/FLINK-4717
>             Project: Flink
>          Issue Type: New Feature
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.2.0
>            Reporter: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.2.0
> As a first step towards atomic stopping with savepoints we should implement a 
> cancel command which prior to cancelling takes a savepoint. Additionally, it 
> should turn off the periodic checkpointing so that there won't be checkpoints 
> executed between the savepoint and the cancel command.

This message was sent by Atlassian JIRA

Reply via email to