pnowojski commented on code in PR #63:
URL: https://github.com/apache/flink-benchmarks/pull/63#discussion_r1098874200
##########
regression_report.py:
##########
@@ -112,8 +114,21 @@ def getMedian(lst):
# If length is odd then get middle value
return lst[len(lst) // 2]
+def isThresholdReached(threshold, baselineValue, comparedValue, lessIsbBetter):
+ ratio = 0
+ if baselineValue != 0:
+ ratio = comparedValue * 100 / baselineValue - 100
+ # regression detected
Review Comment:
I think this comment is miss leading atm. Maybe let's drop it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
