ASF GitHub Bot commented on FLINK-4512:

Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: 
    @@ -64,9 +62,9 @@ public void recover() throws Exception {
        public void addCheckpoint(CompletedCheckpoint checkpoint) throws 
Exception {
    -           checkpoints.addLast(checkpoint);
    +           checkpoints.add(checkpoint);
                if (checkpoints.size() > maxNumberOfCheckpointsToRetain) {
    -                   checkpoints.removeFirst().discardState();
    +                   checkpoints.remove().subsume();
    --- End diff --
    Maybe we shouldn't allow all different combinations of 
`CheckpointProperties`. Only those which make sense.

> Add option for persistent checkpoints
> -------------------------------------
>                 Key: FLINK-4512
>                 URL: https://issues.apache.org/jira/browse/FLINK-4512
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
> Allow periodic checkpoints to be persisted by writing out their meta data. 
> This is what we currently do for savepoints, but in the future checkpoints 
> and savepoints are likely to diverge with respect to guarantees they give for 
> updatability, etc.
> This means that the difference between persistent checkpoints and savepoints 
> in the long term will be that persistent checkpoints can only be restored 
> with the same job settings (like parallelism, etc.)
> Regular and persisted checkpoints should behave differently with respect to 
> disposal in *globally* terminal job states (FINISHED, CANCELLED, FAILED): 
> regular checkpoints are cleaned up in all of these cases whereas persistent 
> checkpoints only on FINISHED. Maybe with the option to customize behaviour on 

This message was sent by Atlassian JIRA

Reply via email to