ASF GitHub Bot commented on FLINK-4512:

Github user uce commented on a diff in the pull request:

    --- Diff: 
    @@ -233,68 +229,90 @@ public int getNumberOfRetainedCheckpoints() {
    -   public void shutdown() throws Exception {
    -           LOG.info("Shutting down");
    +   public void shutdown(JobStatus jobStatus) throws Exception {
    --- End diff --
    Our only option would be to wrap in our own Exception, because Curator is 
throwing the general `Exception`.

> Add option for persistent checkpoints
> -------------------------------------
>                 Key: FLINK-4512
>                 URL: https://issues.apache.org/jira/browse/FLINK-4512
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
> Allow periodic checkpoints to be persisted by writing out their meta data. 
> This is what we currently do for savepoints, but in the future checkpoints 
> and savepoints are likely to diverge with respect to guarantees they give for 
> updatability, etc.
> This means that the difference between persistent checkpoints and savepoints 
> in the long term will be that persistent checkpoints can only be restored 
> with the same job settings (like parallelism, etc.)
> Regular and persisted checkpoints should behave differently with respect to 
> disposal in *globally* terminal job states (FINISHED, CANCELLED, FAILED): 
> regular checkpoints are cleaned up in all of these cases whereas persistent 
> checkpoints only on FINISHED. Maybe with the option to customize behaviour on 

This message was sent by Atlassian JIRA

Reply via email to