lindong28 commented on code in PR #209:
URL: https://github.com/apache/flink-ml/pull/209#discussion_r1101194970
##########
flink-ml-tests/src/test/java/org/apache/flink/test/iteration/BoundedAllRoundCheckpointITCase.java:
##########
@@ -131,16 +129,7 @@ static JobGraph createVariableAndConstantJobGraph(
int maxRound,
int failoverCount,
SinkFunction<OutputRecord<Integer>> sinkFunction) {
- StreamExecutionEnvironment env =
- StreamExecutionEnvironment.getExecutionEnvironment(
- new Configuration() {
- {
- this.set(
- ExecutionCheckpointingOptions
-
.ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH,
- true);
- }
- });
+ StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.getConfig().enableObjectReuse();
Review Comment:
The purpose of FLINK-30688 is to ensure that all algorithms can be run
without using kryo. And this can be verified by having all tests in
flink-ml-lib use `TestUtils.getExecutionEnvironment` to disable kryo.
Now that all tests in flink-ml-lib (except OnlineLogisticRegression) have
used `TestUtils.getExecutionEnvironment` to disable kryo, it seems that we
don't have to use `TestUtils.getExecutionEnvironment ` for those tests in
`flink-ml-iteration`. So I think it is simpler to keep those tests in
`flink-ml-iteration` as is.
I removed the config `ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH` here because
`ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH` is enabled by default since Flink 1.15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
