lindong28 commented on code in PR #209:
URL: https://github.com/apache/flink-ml/pull/209#discussion_r1101197487
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/Benchmark.java:
##########
@@ -78,6 +79,8 @@ private static void executeBenchmarks(CommandLine
commandLine) throws Exception
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
env.getConfig().enableObjectReuse();
+ env.getConfig().disableGenericTypes();
Review Comment:
This change can additionally confirm that all DataGenerators have included
TypeInformation properly so that the benchmarks can be run with kryo disabled.
Since the purpose of the benchmark is to get the maximum possible
performance, I think we will always provide proper type information to make
sure that the benchmarks are run with kryo disabled. This includes the
benchmark for `HashingTF `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
