syhily commented on code in PR #24:
URL:
https://github.com/apache/flink-connector-pulsar/pull/24#discussion_r1103523033
##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/enumerator/PulsarSourceEnumerator.java:
##########
@@ -220,11 +223,14 @@ private void createSubscription(List<TopicPartition>
newPartitions) {
CursorPosition position =
startCursor.position(partition.getTopic(),
partition.getPartitionId());
- if (sourceConfiguration.isResetSubscriptionCursor()) {
- sneakyAdmin(() -> position.seekPosition(pulsarAdmin, topic,
subscriptionName));
- } else {
- sneakyAdmin(
- () -> position.createInitialPosition(pulsarAdmin,
topic, subscriptionName));
+ try {
+ if (sourceConfiguration.isResetSubscriptionCursor()) {
+ position.seekPosition(pulsarAdmin, topic,
subscriptionName);
+ } else {
+ position.createInitialPosition(pulsarAdmin, topic,
subscriptionName);
+ }
+ } catch (PulsarAdminException e) {
+ throw new FlinkRuntimeException(e);
Review Comment:
My bad, we can still throw this exception with a little more works on code
refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
