gaoyunhaii commented on code in PR #21736: URL: https://github.com/apache/flink/pull/21736#discussion_r1104239366
########## flink-core/pom.xml: ########## @@ -18,148 +18,203 @@ specific language governing permissions and limitations under the License. --> <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; - xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> - - <modelVersion>4.0.0</modelVersion> - - <parent> - <groupId>org.apache.flink</groupId> - <artifactId>flink-parent</artifactId> - <version>1.17-SNAPSHOT</version> - </parent> - - <artifactId>flink-core</artifactId> - <name>Flink : Core</name> - - <packaging>jar</packaging> - - <dependencies> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-annotations</artifactId> - <version>${project.version}</version> - </dependency> - - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-metrics-core</artifactId> - <version>${project.version}</version> - </dependency> - - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-shaded-asm-9</artifactId> - </dependency> - - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-shaded-jackson</artifactId> - </dependency> - - <!-- standard utilities --> - <dependency> - <groupId>org.apache.commons</groupId> - <artifactId>commons-lang3</artifactId> - <!-- managed version --> - </dependency> - - <!-- standard utilities --> - <dependency> - <groupId>org.apache.commons</groupId> - <artifactId>commons-text</artifactId> - <!-- managed version --> - </dependency> - - <!-- for the fallback generic serializer --> - <dependency> - <groupId>com.esotericsoftware.kryo</groupId> - <artifactId>kryo</artifactId> - <!-- managed version --> - </dependency> - - <!-- The common collections are needed for some hash tables used in the collection execution --> - <dependency> - <groupId>commons-collections</groupId> - <artifactId>commons-collections</artifactId> - <!-- managed version --> - </dependency> - - <!-- Commons compression, for additional decompressors --> - <dependency> - <groupId>org.apache.commons</groupId> - <artifactId>commons-compress</artifactId> - <!-- managed version --> - </dependency> - <dependency> - <groupId>com.github.luben</groupId> - <artifactId>zstd-jni</artifactId> - <version>1.4.9-1</version> - <scope>test</scope> - </dependency> - - - <!-- Ratelimiting dependencies --> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-shaded-guava</artifactId> - </dependency> - - <!-- ================== test dependencies ================== --> - - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-test-utils-junit</artifactId> - </dependency> - - <!-- Joda, jackson, and lombok are used to test that serialization and type extraction - work with types from those libraries --> - - <dependency> - <groupId>joda-time</groupId> - <artifactId>joda-time</artifactId> - <scope>test</scope> - </dependency> - - <dependency> - <groupId>org.joda</groupId> - <artifactId>joda-convert</artifactId> - <scope>test</scope> - </dependency> - - <dependency> - <groupId>org.projectlombok</groupId> - <artifactId>lombok</artifactId> - <version>1.18.22</version> - <scope>test</scope> - </dependency> - - </dependencies> - - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-checkstyle-plugin</artifactId> - - <configuration> - <suppressionsLocation combine.self="override">/tools/maven/suppressions-core.xml</suppressionsLocation> - </configuration> - </plugin> - - <!-- publish some test base classes --> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-jar-plugin</artifactId> - <executions> - <execution> - <goals> - <goal>test-jar</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - - </build> - + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-parent</artifactId> + <version>1.17-SNAPSHOT</version> + </parent> + + <artifactId>flink-core</artifactId> + <name>Flink : Core</name> + + <packaging>jar</packaging> + + <dependencies> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-annotations</artifactId> + <version>${project.version}</version> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-metrics-core</artifactId> + <version>${project.version}</version> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-shaded-asm-9</artifactId> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-shaded-jackson</artifactId> + </dependency> + + <!-- standard utilities --> + <dependency> + <groupId>org.apache.commons</groupId> + <artifactId>commons-lang3</artifactId> + <!-- managed version --> + </dependency> + + <!-- standard utilities --> + <dependency> + <groupId>org.apache.commons</groupId> + <artifactId>commons-text</artifactId> + <!-- managed version --> + </dependency> + + <!-- for the fallback generic serializer --> + <dependency> + <groupId>com.esotericsoftware.kryo</groupId> + <artifactId>kryo</artifactId> + <!-- managed version --> + </dependency> + + <!-- The common collections are needed for some hash tables used in the collection execution --> + <dependency> + <groupId>commons-collections</groupId> + <artifactId>commons-collections</artifactId> + <!-- managed version --> + </dependency> + + <!-- Commons compression, for additional decompressors --> + <dependency> + <groupId>org.apache.commons</groupId> + <artifactId>commons-compress</artifactId> + <!-- managed version --> + </dependency> + <dependency> + <groupId>com.github.luben</groupId> + <artifactId>zstd-jni</artifactId> + <version>1.4.9-1</version> + <scope>test</scope> + </dependency> + + + <!-- Ratelimiting dependencies --> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-shaded-guava</artifactId> + </dependency> + + <!-- ================== test dependencies ================== --> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-test-utils-junit</artifactId> + </dependency> + + <!-- Joda, jackson, and lombok are used to test that serialization and type extraction + work with types from those libraries --> + + <dependency> + <groupId>joda-time</groupId> + <artifactId>joda-time</artifactId> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.joda</groupId> + <artifactId>joda-convert</artifactId> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.projectlombok</groupId> + <artifactId>lombok</artifactId> + <version>1.18.22</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>fink-migration-test-utils</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + + </dependencies> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-checkstyle-plugin</artifactId> + + <configuration> + <suppressionsLocation combine.self="override">/tools/maven/suppressions-core.xml + </suppressionsLocation> Review Comment: This is change by accident. I'll revert the format change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
