gaoyunhaii commented on code in PR #21736:
URL: https://github.com/apache/flink/pull/21736#discussion_r1105853094
##########
flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java:
##########
@@ -66,7 +58,22 @@
* Creates a collection of {@link TestSpecification} which will be used as
input for
* parametrized tests.
*/
- public abstract Collection<TestSpecification<?, ?>>
createTestSpecifications() throws Exception;
+ public abstract Collection<TestSpecification<?, ?>>
createTestSpecifications(
Review Comment:
I think although Previously although the generating methods is executed for
each specification, in each pass it executes the logic bound go
`CURRENT_VERSION`:
https://github.com/apache/flink/blob/057dbc5f62a5fce2b03de1c0a74a064ebbe9ac3e/flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerUpgradeTestBase.java#L271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
