[ 
https://issues.apache.org/jira/browse/FLINK-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568255#comment-15568255
 ] 

ASF GitHub Bot commented on FLINK-4691:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2562#discussion_r82968570
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/TimeIntervalTypeInfo.scala
 ---
    @@ -24,14 +24,14 @@ import org.apache.flink.api.common.ExecutionConfig
     import org.apache.flink.api.common.typeinfo.{AtomicType, TypeInformation}
     import org.apache.flink.api.common.typeutils.base.{IntComparator, 
IntSerializer, LongComparator, LongSerializer}
     import org.apache.flink.api.common.typeutils.{TypeComparator, 
TypeSerializer}
    -import 
org.apache.flink.api.table.typeutils.IntervalTypeInfo.instantiateComparator
    +import 
org.apache.flink.api.table.typeutils.TimeIntervalTypeInfo.instantiateComparator
     import org.apache.flink.util.Preconditions._
     
     /**
       * TypeInformation for SQL INTERVAL types.
       */
     @SerialVersionUID(-1816179424364825258L)
    -class IntervalTypeInfo[T](
    +class TimeIntervalTypeInfo[T](
    --- End diff --
    
    Define `TimeIntervalTypeInfo` as 
    ```
    class TimeIntervalTypeInfo[T](
        val clazz: Class[T],
        val serializer: TypeSerializer[T],
        val comparatorClazz: Class[_ <: TypeComparator[T]])
      extends IntegerTypeInfo[T](
        clazz,
        Array[Class[_]](classOf[Float], classOf[Double], classOf[Character]),
        serializer,
        comparatorClazz)
    
    object TimeIntervalTypeInfo {
    
      val INTERVAL_MONTHS = new TimeIntervalTypeInfo(
        classOf[java.lang.Integer],
        IntSerializer.INSTANCE,
        classOf[IntComparator])
    
      val INTERVAL_MILLIS = new TimeIntervalTypeInfo(
        classOf[java.lang.Long],
        LongSerializer.INSTANCE,
        classOf[LongComparator])
    
    }
    ```


> Add group-windows for streaming tables        
> ---------------------------------------
>
>                 Key: FLINK-4691
>                 URL: https://issues.apache.org/jira/browse/FLINK-4691
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>
> Add Tumble, Slide, Session group-windows for streaming tables as described in 
> [FLIP-11|https://cwiki.apache.org/confluence/display/FLINK/FLIP-11%3A+Table+API+Stream+Aggregations].
>  
> Implementation of group-windows on streaming tables. This includes 
> implementing the API of group-windows, the logical validation for 
> group-windows, and the definition of the “rowtime” and “systemtime” keywords. 
> Group-windows on batch tables won’t be initially supported and will throw an 
> exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to