[ 
https://issues.apache.org/jira/browse/FLINK-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15568319#comment-15568319
 ] 

ASF GitHub Bot commented on FLINK-4512:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2608#discussion_r82976869
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointLoader.java
 ---
    @@ -48,13 +48,12 @@
        public static CompletedCheckpoint loadAndValidateSavepoint(
                        JobID jobId,
                        Map<JobVertexID, ExecutionJobVertex> tasks,
    -                   SavepointStore savepointStore,
                        String savepointPath) throws Exception {
     
                // (1) load the savepoint
    -           Savepoint savepoint = 
savepointStore.loadSavepoint(savepointPath);
    +           Savepoint savepoint = 
SavepointStore.loadSavepoint(savepointPath);
                final Map<JobVertexID, TaskState> taskStates = new 
HashMap<>(savepoint.getTaskStates().size());
    -           
    +
                // (2) validate it (parallelism, etc)
                for (TaskState taskState : savepoint.getTaskStates()) {
                        ExecutionJobVertex executionJobVertex = 
tasks.get(taskState.getJobVertexID());
    --- End diff --
    
    Yes, updated.


> Add option for persistent checkpoints
> -------------------------------------
>
>                 Key: FLINK-4512
>                 URL: https://issues.apache.org/jira/browse/FLINK-4512
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>
> Allow periodic checkpoints to be persisted by writing out their meta data. 
> This is what we currently do for savepoints, but in the future checkpoints 
> and savepoints are likely to diverge with respect to guarantees they give for 
> updatability, etc.
> This means that the difference between persistent checkpoints and savepoints 
> in the long term will be that persistent checkpoints can only be restored 
> with the same job settings (like parallelism, etc.)
> Regular and persisted checkpoints should behave differently with respect to 
> disposal in *globally* terminal job states (FINISHED, CANCELLED, FAILED): 
> regular checkpoints are cleaned up in all of these cases whereas persistent 
> checkpoints only on FINISHED. Maybe with the option to customize behaviour on 
> CANCELLED or FAILED.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to