ASF GitHub Bot commented on FLINK-4512:

Github user uce commented on a diff in the pull request:

    --- Diff: 
    @@ -48,13 +48,12 @@
        public static CompletedCheckpoint loadAndValidateSavepoint(
                        JobID jobId,
                        Map<JobVertexID, ExecutionJobVertex> tasks,
    -                   SavepointStore savepointStore,
                        String savepointPath) throws Exception {
                // (1) load the savepoint
    -           Savepoint savepoint = 
    +           Savepoint savepoint = 
                final Map<JobVertexID, TaskState> taskStates = new 
                // (2) validate it (parallelism, etc)
                for (TaskState taskState : savepoint.getTaskStates()) {
                        ExecutionJobVertex executionJobVertex = 
    --- End diff --
    Yes, updated.

> Add option for persistent checkpoints
> -------------------------------------
>                 Key: FLINK-4512
>                 URL: https://issues.apache.org/jira/browse/FLINK-4512
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
> Allow periodic checkpoints to be persisted by writing out their meta data. 
> This is what we currently do for savepoints, but in the future checkpoints 
> and savepoints are likely to diverge with respect to guarantees they give for 
> updatability, etc.
> This means that the difference between persistent checkpoints and savepoints 
> in the long term will be that persistent checkpoints can only be restored 
> with the same job settings (like parallelism, etc.)
> Regular and persisted checkpoints should behave differently with respect to 
> disposal in *globally* terminal job states (FINISHED, CANCELLED, FAILED): 
> regular checkpoints are cleaned up in all of these cases whereas persistent 
> checkpoints only on FINISHED. Maybe with the option to customize behaviour on 

This message was sent by Atlassian JIRA

Reply via email to