Jiabao-Sun commented on code in PR #3:
URL:
https://github.com/apache/flink-connector-mongodb/pull/3#discussion_r1108627598
##########
flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/split/MongoSourceSplitState.java:
##########
@@ -19,28 +19,19 @@
import org.apache.flink.annotation.PublicEvolving;
+import org.bson.BsonDocument;
+
/** MongoDB source split state. */
@PublicEvolving
-public class MongoSourceSplitState {
+public abstract class MongoSourceSplitState {
Review Comment:
Thanks @zentol for the review.
The main purpose of making these abstractions is to realize unbounded CDC
reading in future by [Change
Streams](https://www.mongodb.com/docs/manual/changeStreams/#change-streams)
feature.
And the offset of the change stream split may be a `BsonDocument` type
`ResumeToken` which can be extracted from a change record.
- The `updateOffset` method provides a change record parameter to extract
ResumeToken.
- The offset has different data types so we may have some different
`SplitState`.
But as you say, it probably doesn't need to be changed prematurely in order
to fix this problem.
Do we need to remove these modifications?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
