lilyevsky commented on code in PR #11:
URL:
https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110040361
##########
flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchWriterITCase.java:
##########
@@ -174,7 +175,8 @@ void testIncrementByteOutMetric() throws Exception {
new BulkProcessorConfig(flushAfterNActions, -1, -1,
FlushBackoffType.NONE, 0, 0);
try (final OpensearchWriter<Tuple2<Integer, String>> writer =
- createWriter(index, false, bulkProcessorConfig, metricGroup)) {
+ createWriter(
Review Comment:
Agreed, it will be better not to touch that line. I did it because it needed
to pass the metricGroup.
So I am fixing the situation by adding yet another constructor, with
metricGroup but without failureHandler.
Also in the main constructor put the failureHandler at the end of the
parameters list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
