[
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569021#comment-15569021
]
Timo Walther commented on FLINK-4604:
-------------------------------------
You cannot use {{!AggregateReduceFunctionsRule.INSTANCE.matches(call)}} as it
is always false for sums. See
{{AggregateReduceFunctionsRule.containsAvgStddevVarCall}}.
What do you mean with "something went wrong"? What about this:
{code}
val supported = agg.getAggCallList.map(_.getAggregation.getKind).forall {
case SqlKind.SUM => true
case SqlKind.MIN => true
case SqlKind.MAX => true
case _ => false
}
!distinctAggs && !groupSets && !agg.indicator && supported
{code}
> Add support for standard deviation/variance
> -------------------------------------------
>
> Key: FLINK-4604
> URL: https://issues.apache.org/jira/browse/FLINK-4604
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Anton Mushin
> Attachments: 1.jpg
>
>
> Calcite's {{AggregateReduceFunctionsRule}} can convert SQL {{AVG, STDDEV_POP,
> STDDEV_SAMP, VAR_POP, VAR_SAMP}} to sum/count functions. We should add, test
> and document this rule.
> If we also want to add this aggregates to Table API is up for discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
