[ 
https://issues.apache.org/jira/browse/FLINK-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621663#comment-15621663
 ] 

Anton Mushin commented on FLINK-4604:
-------------------------------------

bq. We can later remove these commits once the original PR got merged.
I'm already merge this PR as patch
bq. Regarding the Type NULL issue, are you still working on the branch you 
posted previously in this thread: BRANCH? 
Yes, I working in this 
[branch|https://github.com/ex00/flink/compare/master...ex00:FLINK-4604].
bq.I assume you get the exception when running one of tests, right?
Yes, I have 2 tests: 
{{org.apache.flink.api.scala.batch.sql.AggregationsITCase#testStddevPopAggregateWithOtherAggreagteSUM0}}
 and 
{{org.apache.flink.api.scala.batch.sql.AggregationsITCase#testStddevPopAggregateWithOtherAggreagteSUM}}.
 
{{testStddevPopAggregateWithOtherAggreagteSUM0}} is passing
{{testStddevPopAggregateWithOtherAggreagteSUM}} is failing

> Add support for standard deviation/variance
> -------------------------------------------
>
>                 Key: FLINK-4604
>                 URL: https://issues.apache.org/jira/browse/FLINK-4604
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Anton Mushin
>         Attachments: 1.jpg
>
>
> Calcite's {{AggregateReduceFunctionsRule}} can convert SQL {{AVG, STDDEV_POP, 
> STDDEV_SAMP, VAR_POP, VAR_SAMP}} to sum/count functions. We should add, test 
> and document this rule. 
> If we also want to add this aggregates to Table API is up for discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to