fsk119 commented on code in PR #21945:
URL: https://github.com/apache/flink/pull/21945#discussion_r1112502607
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/rest/serde/LogicalTypeJsonSerializer.java:
##########
@@ -87,6 +89,10 @@ public final class LogicalTypeJsonSerializer extends
StdSerializer<LogicalType>
public static final String FIELD_NAME_CLASS = "class";
public static final String FIELD_NAME_SERIALIZER = "serializer";
+ // INTERVAL
Review Comment:
`INTERVAL` is a kind of `DataType` in the doc[1]. I think the API here aims
at the DataType rather than LogicalType in the design[2].
[1]
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/types/#list-of-data-types
[2]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-91%3A+Support+SQL+Gateway#FLIP91:SupportSQLGateway-SerializeanddeserializetheResultSet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
