[
https://issues.apache.org/jira/browse/FLINK-30407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691340#comment-17691340
]
Shipeng Xie edited comment on FLINK-30407 at 2/21/23 4:59 AM:
--------------------------------------------------------------
Hi [~gyfora] , could you tell me more about the context of this ticket?
Currently, DeploymentFailedException, MissingJobManagerException and
UnknownJobException apply to FlinkDeployment only. MissingSessionJobException
applies to SessionJob only. Most of common exception handler code in
controllers is in ReconcilationUtils and EventRecorder.
Do you suggest any specific part of the duplicated code that we can reduce?
was (Author: JIRAUSER296422):
Hi [~gyfora] , I would like to know more about the context of this ticket.
Currently, DeploymentFailedException, MissingJobManagerException and
UnknownJobException apply to FlinkDeployment only. MissingSessionJobException
applies to SessionJob only. Most of common exception handler code in
controllers is in ReconcilationUtils and EventRecorder.
Do you suggest any specific part of the duplicated code that we can reduce?
> Better encapsulate error handling logic in controllers
> ------------------------------------------------------
>
> Key: FLINK-30407
> URL: https://issues.apache.org/jira/browse/FLINK-30407
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
> Reporter: Gyula Fora
> Assignee: Shipeng Xie
> Priority: Major
> Labels: starter
>
> The error handling in the FlinkDeployment and SessionJobControllers are a bit
> adhoc and mostly consist of a series of try catch blocks.
> We should introduce a set of error handlers that we can encapsulate nicely
> and share between the controllers to reduce code duplication.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
