[
https://issues.apache.org/jira/browse/FLINK-31167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691530#comment-17691530
]
Matthias Pohl commented on FLINK-31167:
---------------------------------------
FLINK-30798 introduced a few exclusions:
* [642d28ec|https://github.com/apache/flink/commit/642d28ec] for
{{FinalizeOnMaster}}: why do we add an empty default implementation for
{{FinalizeOnMaster.finalizeGlobal(int)}}. Isn't only the
{{finalizeGlobal(FinalizationContext)}} default implementation necessary?
* [74ef6be4|https://github.com/apache/flink/commit/74ef6be4] for
{{OutputFormat}}: the same question applies here for the deprecated
{{OutputFormat.open(int, int)}}.
[~SleePy] I guess it is to make new implementations easier?
> Verify that no exclusions were erroneously added to the japicmp plugin
> ----------------------------------------------------------------------
>
> Key: FLINK-31167
> URL: https://issues.apache.org/jira/browse/FLINK-31167
> Project: Flink
> Issue Type: Sub-task
> Reporter: Matthias Pohl
> Assignee: Matthias Pohl
> Priority: Major
>
> Verify that no exclusions were erroneously added to the japicmp plugin that
> break compatibility guarantees. Check the exclusions for the
> japicmp-maven-plugin in the root pom (see
> [apache/flink:pom.xml:2175ff|https://github.com/apache/flink/blob/3856c49af77601cf7943a5072d8c932279ce46b4/pom.xml#L2175]
> for exclusions that:
> * For minor releases: break source compatibility for {{@Public}} APIs
> * For patch releases: break source/binary compatibility for
> {{@Public}}/{{@PublicEvolving}} APIs
> Any such exclusion must be properly justified, in advance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
