[
https://issues.apache.org/jira/browse/FLINK-31167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691970#comment-17691970
]
Biao Liu commented on FLINK-31167:
----------------------------------
Hi [~mapohl] ,
As you mentioned, the new method with context were introduced to replace the
old one.
Let's take the {{finalizeGlobal}} as an example. If we do not provide the
default implementation for {{finalizeGlobal(int)}} and someone wants to use the
new method with context, he has to implement both {{finalizeGlobal(int)}} and
{{finalizeGlobal(FinalizationContext)}} even the former one means nothing to
him.
That's not we expect users to do. The {{finalizeGlobal(int)}} works for the
legacy codes, and {{finalizeGlobal(FinalizationContext)}} works for the new
implementation. Users only need to implement one of them. It's sort of like how
SinkFunction is handled in https://issues.apache.org/jira/browse/FLINK-7552.
I think it's not a breaking change however it could not pass the japicmp
checking.
> Verify that no exclusions were erroneously added to the japicmp plugin
> ----------------------------------------------------------------------
>
> Key: FLINK-31167
> URL: https://issues.apache.org/jira/browse/FLINK-31167
> Project: Flink
> Issue Type: Sub-task
> Reporter: Matthias Pohl
> Assignee: Matthias Pohl
> Priority: Major
>
> Verify that no exclusions were erroneously added to the japicmp plugin that
> break compatibility guarantees. Check the exclusions for the
> japicmp-maven-plugin in the root pom (see
> [apache/flink:pom.xml:2175ff|https://github.com/apache/flink/blob/3856c49af77601cf7943a5072d8c932279ce46b4/pom.xml#L2175]
> for exclusions that:
> * For minor releases: break source compatibility for {{@Public}} APIs
> * For patch releases: break source/binary compatibility for
> {{@Public}}/{{@PublicEvolving}} APIs
> Any such exclusion must be properly justified, in advance.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
