1996fanrui commented on PR #21999: URL: https://github.com/apache/flink/pull/21999#issuecomment-1440165179
Hi @akalash , thanks for your quick feedback. > how urgent is this PR ? I think it isn't very urgent. > Can we wait for merging #21923?(I think it helps you avoid a new flag) Yeah, #21923 is very useful for maintainability. However, I recommend fixing the bug before refactoring the state machine for two reasons: 1. After the introduction of initializing, the state of TaskState will become more complicated, and FLINK-13871 will do more thought when designing TaskState. If we design TaskState first, not sure if it will be easily compatible with initializing in the future. 2. Fix bugs before refactoring the state machine, it will be easier to backport the bugfix to 1.16 and 1.17. Anyway, I don't have strong opinion about which PR is merged first. If #21923 is merged first, we need to consider the scalability of TaskState. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
