akalash commented on code in PR #21999:
URL: https://github.com/apache/flink/pull/21999#discussion_r1114460469
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -689,6 +695,7 @@ void restoreInternal() throws Exception {
LOG.debug("Re-restore attempt rejected.");
return;
}
+ isInitializing = true;
Review Comment:
I don't see where `isInitializing` is set to `false`
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java:
##########
@@ -261,6 +261,12 @@
*/
private volatile boolean isRunning;
+ /**
+ * Flag to mark the task "in operation", in which case check needs to be
process the exceptions
+ * thrown in the initializing duration.
+ */
+ private volatile boolean isInitializing;
Review Comment:
Maybe `isRestoring`? I am not sure which is better name but it seems that we
have run now two clear steps 'restoring' and 'invoking'('running') so maybe it
is better just to have a flag 'restoring' for 'restoring' step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
