dannycranmer commented on code in PR #22000:
URL: https://github.com/apache/flink/pull/22000#discussion_r1115370196
##########
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/FanOutShardSubscriber.java:
##########
@@ -452,7 +477,7 @@ public void onComplete() {
}
private void cancelSubscription() {
- if (cancelled) {
+ if (isCancelled()) {
Review Comment:
_Should not_ happen, since the AWS SDK client `.close()` method is called
during shutdown. I need to add this check here because we also saw
`RejectedExecutionException` thrown from `subscription.cancel()` a few lines
down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
