snuyanzin commented on code in PR #21993:
URL: https://github.com/apache/flink/pull/21993#discussion_r1117070060
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java:
##########
@@ -71,7 +71,11 @@ public final class SpecificInputTypeStrategies {
/** Argument type derived from the array element type. */
public static final ArgumentTypeStrategy ARRAY_ELEMENT_ARG =
- new ArrayElementArgumentTypeStrategy();
+ new ArrayElementArgumentTypeStrategy(false);
+
+ /** Argument type derived from the array element type. But leaves
nullability untouched. */
Review Comment:
"preserving" means keeping same.
With current implementation if an input array is an array of not null ints
and input parameter for `ArrayElementArgumentTypeStrategy` constructor is
`true` then it will force set to nullable.
So it does different thing and not preserving
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
