tamirsagi commented on code in PR #536: URL: https://github.com/apache/flink-kubernetes-operator/pull/536#discussion_r1118517610
########## Dockerfile: ########## @@ -36,13 +36,16 @@ RUN cd /app/tools/license; mkdir jars; cd jars; \ # stage FROM eclipse-temurin:11-jre-jammy ENV FLINK_HOME=/opt/flink -ENV FLINK_PLUGINS_DIR=/opt/flink/plugins +ENV FLINK_PLUGINS_DIR=$FLINK_HOME/plugins ENV OPERATOR_VERSION=1.5-SNAPSHOT ENV OPERATOR_JAR=flink-kubernetes-operator-$OPERATOR_VERSION-shaded.jar ENV AUTOSCALER_JAR=flink-kubernetes-operator-autoscaler-$OPERATOR_VERSION.jar ENV WEBHOOK_JAR=flink-kubernetes-webhook-$OPERATOR_VERSION-shaded.jar ENV FLINK_KUBERNETES_SHADED_JAR=flink-kubernetes-standalone-$OPERATOR_VERSION-shaded.jar +ENV USER_DEPENDENCIES_DIR=$FLINK_HOME/dependencies +RUN mkdir -p $USER_DEPENDENCIES_DIR Review Comment: I did not want to mix up user jar located under 'usrlib' in Flink application and user dependencies on Flink operator. You think it's better to keep under same name? maybe opt/flink/usrlib/dependencies? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
