pgaref commented on PR #21923: URL: https://github.com/apache/flink/pull/21923#issuecomment-1447279707
Thanks everyone for the useful comments! PTAL on the latest changes, in short: - Checked all state transitions and documented them as part of https://github.com/apache/flink/pull/21923/files#diff-0c5fe245445b932fa83fdaf5c4802dbe671b73e8d76f39058c6eaaaffd9639faR268 - Integrated **Restoring** state introduced as part of [FLINK-29816](https://issues.apache.org/jira/browse/FLINK-29816) - Added **Failing** as a separate State boolean field in TaskSate object (can always rework this as a followup) - Refrained from adding state transition validation as this is already happening as part of Task ExecutionState https://github.com/apache/flink/blob/8be94e6663d8ac6e3d74bf4cd5f540cc96c8289e/flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java#L907 Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
