pgaref commented on PR #21923: URL: https://github.com/apache/flink/pull/21923#issuecomment-1445719083
> Hi @pgaref , thanks a lot for the refactor, it's very useful for maintainability. I have left some comments, please help take a look in your free time, thanks~ > > Thanks @pnowojski @akalash @rkhachatryan 's review. I found [FLINK-29816](https://issues.apache.org/jira/browse/FLINK-29816)[1] related to this TaskState, and I think it should be fixed first, what do you think? > > [1] https://issues.apache.org/jira/browse/FLINK-29816?focusedCommentId=17692203&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17692203 @1996fanrui thanks for the comments! Let me rework the patch addressing the comments now that [FLINK-29816](https://issues.apache.org/jira/browse/FLINK-29816) is merged :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org