reta commented on PR #5:
URL:
https://github.com/apache/flink-connector-opensearch/pull/5#issuecomment-1453764023
Thanks a lot for review @dannycranmer
> @reta The PR looks good to me minus the Mockito comment. However I have
questions over the approach here. We are adding a new sink alongside the
existing sink, we will have `OpensearchSink` and `OpensearchAsyncSink`. How do
the users know which one to pick? Why not replace the existing sink with the
new implementation?
This is a indeed a good question, I think the main difference between those
are within internal APIs the implementation is based upon:
- `OpensearchAsyncSink` uses `RestHighLevelClient::bulkdAsync` directly to
dispatch the bulk requests
- `OpensearchSink` uses `BulkProcessor` and offers more flexibility with
respect to failure handling and backoff policies (no straight equivalent in
`RestHighLevelClient`)
I have covered this part in the docs, thank you.
> The [Jira](https://issues.apache.org/jira/browse/FLINK-31068) mentions
docs, however there is no update here. Will you create a followup PR for that?
>
Updated the documentation, thank you
> If this has already been discussed on mailing lists I missed that, please
give me a link :D
You mean the `AsyncSync` implementation for OpenSearch? No, it was not
discussed on mailing list but was mentioned on the initial pull request
https://github.com/apache/flink/pull/18541#issuecomment-1026931087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
