ASF GitHub Bot commented on FLINK-4784:

GitHub user zentol opened a pull request:


    [FLINK-4784] Unique MetricQueryService actor names

    This PR makes the MetricQueryService actor name unique by appending the 
TaskManagers resource id. For the jobmanager nothing is appended.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 4784_metrics_actor_names

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2636
commit e2950e27b3c37c72c63bfe48c30f56e8b497d5a4
Author: zentol <ches...@apache.org>
Date:   2016-10-10T08:40:10Z

    [FLINK-4784] Unique MetricQueryService actor names


> MetricQueryService actor name collision
> ---------------------------------------
>                 Key: FLINK-4784
>                 URL: https://issues.apache.org/jira/browse/FLINK-4784
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.2
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.2.0
> The name of the MetricQueryService actor is currently fixed, which can lead 
> to collisions if multiple TaskManagers run in the same actor system, as is 
> the case for the MiniCluster.
> We can append the TaskManager ResourceID to make the name unique for every 
> TaskManager. The MetricFetcher would still be able to reliable infer the 
> correct actor name.

This message was sent by Atlassian JIRA

Reply via email to