[
https://issues.apache.org/jira/browse/FLINK-4784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589224#comment-15589224
]
ASF GitHub Bot commented on FLINK-4784:
---------------------------------------
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2636#discussion_r84115204
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricFetcher.java
---
@@ -148,7 +148,7 @@ public void onSuccess(Object result) throws Throwable {
activeTaskManagers.add(taskManager.getId().toString());
String
taskManagerPath = taskManager.getActorGateway().path();
- String
queryServicePath = taskManagerPath.substring(0,
taskManagerPath.lastIndexOf('/') + 1) + "MetricQueryService";
+ String
queryServicePath = taskManagerPath.substring(0,
taskManagerPath.lastIndexOf('/') + 1) + "MetricQueryService_" +
taskManager.getTaskManagerID().toString();
--- End diff --
You could use the `MetricQueryService.METRIC_QUERY_SERVICE_NAME` constant
here
> MetricQueryService actor name collision
> ---------------------------------------
>
> Key: FLINK-4784
> URL: https://issues.apache.org/jira/browse/FLINK-4784
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.2
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.2.0
>
>
> The name of the MetricQueryService actor is currently fixed, which can lead
> to collisions if multiple TaskManagers run in the same actor system, as is
> the case for the MiniCluster.
> We can append the TaskManager ResourceID to make the name unique for every
> TaskManager. The MetricFetcher would still be able to reliable infer the
> correct actor name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
