reswqa commented on code in PR #22084:
URL: https://github.com/apache/flink/pull/22084#discussion_r1127499052
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java:
##########
@@ -669,6 +669,13 @@ public void setNumBuffers(int numBuffers) {
currentPoolSize = Math.min(numBuffers, maxNumberOfMemorySegments);
+ // reset overdraft buffers
+ while (numberOfRequestedOverdraftMemorySegments > 0
+ && numberOfRequestedMemorySegments < currentPoolSize) {
Review Comment:
For the case that the pool size becomes smaller, I prefer not to do special
handling, because we already allow the case that `numRequestedBuffers` exceed
the `pool size` after `setNumbers`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
