reswqa commented on code in PR #22084:
URL: https://github.com/apache/flink/pull/22084#discussion_r1128926904
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java:
##########
@@ -669,6 +669,13 @@ public void setNumBuffers(int numBuffers) {
currentPoolSize = Math.min(numBuffers, maxNumberOfMemorySegments);
+ // reset overdraft buffers
+ while (numberOfRequestedOverdraftMemorySegments > 0
+ && numberOfRequestedMemorySegments < currentPoolSize) {
Review Comment:
The reason why I didn't do this convert here is that we have an upper limit
on the number of overdraft buffers. If this conversion is allowed, and the
`pool size` changes very small, the `numberOfRequestedOverdraftMemorySegments `
will exceed its upper limit.
Of course, we can convert it to the upper limit at most, but this will make
the logic a little complicated. It seems that there is no benefit to introduce
this mechanism. WDTY?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
