gyfora commented on code in PR #546:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/546#discussion_r1128753730
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/metrics/MetricAggregator.java:
##########
@@ -34,7 +33,11 @@ public enum MetricAggregator {
this.getter = getter;
}
- public Optional<Double> get(AggregatedMetric metric) {
- return Optional.ofNullable(metric).map(getter).filter(d -> !d.isNaN());
+ public double get(AggregatedMetric metric) {
+ if (metric != null) {
+ return getter.apply(metric);
+ } else {
+ return Double.NaN;
+ }
Review Comment:
This change here could be the reason why the lag growth rate may be nan
after this.
Before this commit after your pending record related change the lag would be
0 , and now this may return Double.nan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
