liuyongvs commented on PR #22144: URL: https://github.com/apache/flink/pull/22144#issuecomment-1463213377
hi @snuyanzin @twalthr after talking in https://github.com/apache/flink/pull/21947 1) do not support array_size, which can be replaced by CARDINALITY 2) the select array_remove(array[1, 2], cast(null as int)); throw exception, which is fixed and merge in https://github.com/apache/flink/commit/10dce7cf0a04b80d7416a5760e1a6dbc430d9f88 3) the java equals may cause bug in array_distinct, should use ExpressionEvaluator, suggested by @twalthr which is fixed and merge in https://github.com/apache/flink/commit/6797d6f2592373b2606ddd8c8aad316d677c1cc6 4) the last problem found in https://github.com/apache/flink/pull/22143#issuecomment-1463191208, will also need to be solved so it is the time to implment other array functions. so i submit a new PR, could you help to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
