snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1134622026
########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayRemoveFunction.java: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.functions.scalar; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.data.ArrayData; +import org.apache.flink.table.data.GenericArrayData; +import org.apache.flink.table.functions.BuiltInFunctionDefinitions; +import org.apache.flink.table.functions.FunctionContext; +import org.apache.flink.table.functions.SpecializedFunction; +import org.apache.flink.table.types.CollectionDataType; +import org.apache.flink.table.types.DataType; +import org.apache.flink.util.FlinkRuntimeException; + +import javax.annotation.Nullable; + +import java.lang.invoke.MethodHandle; +import java.util.ArrayList; +import java.util.List; + +import static org.apache.flink.table.api.Expressions.$; + +/** Implementation of {@link BuiltInFunctionDefinitions#ARRAY_REMOVE}. */ +@Internal +public class ArrayRemoveFunction extends BuiltInScalarFunction { + private final ArrayData.ElementGetter elementGetter; + private final SpecializedFunction.ExpressionEvaluator equalityEvaluator; + private transient MethodHandle equalityHandle; + + public ArrayRemoveFunction(SpecializedFunction.SpecializedContext context) { + super(BuiltInFunctionDefinitions.ARRAY_REMOVE, context); + final DataType elementDataType = + ((CollectionDataType) context.getCallContext().getArgumentDataTypes().get(0)) + .getElementDataType(); + final DataType needleDataType = context.getCallContext().getArgumentDataTypes().get(1); + elementGetter = ArrayData.createElementGetter(elementDataType.getLogicalType()); + equalityEvaluator = + context.createEvaluator( + $("element").isEqual($("needle")), + DataTypes.BOOLEAN(), + DataTypes.FIELD("element", elementDataType.notNull().toInternal()), + DataTypes.FIELD("needle", needleDataType.notNull().toInternal())); + } + + @Override + public void open(FunctionContext context) throws Exception { + equalityHandle = equalityEvaluator.open(context); + } + + public @Nullable ArrayData eval(ArrayData haystack, Object needle) { + try { + if (haystack == null) { + return null; + } + + List list = new ArrayList(); + final int size = haystack.size(); + for (int pos = 0; pos < size; pos++) { + final Object element = elementGetter.getElementOrNull(haystack, pos); + if ((element == null && needle != null) + || (element != null && needle == null) + || (element != null + && needle != null + && !(boolean) equalityHandle.invoke(element, needle))) { Review Comment: This could be simplified e.g. check for the negative case and continue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
