reswqa opened a new pull request, #22161: URL: https://github.com/apache/flink/pull/22161
## What is the purpose of the change *In general, we want to avoid relying on local timeouts in the Flink test suite to get additional context (thread dump) in case something gets stuck(see [Code Style and Quality Guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#avoid-timeouts-in-junit-tests)). Some of timeout in tests are introduced by assertions for CompleteFuture. After [FLINK-31385](https://issues.apache.org/jira/browse/FLINK-31385), we can refactor these tests to git rid of timeout for CompletableFuture assertions.* *In the process of removing all assertions with timeout for `CompletableFuture`, I found that some tests actually want to assert that a `future` will not be completed in a certain time. For example, `JobMasterServiceLeadershipRunnerTest#testConcurrentLeadershipOperationsBlockingClose`. This logic was first covered by `org.apache.flink.core.testutils.FlinkMatchers#willNotComplete`, and then depends on the `failsWithin` timeout mechanism after migrating to `assertJ`. In order not to change the original test logic, the timeout here has not been removed.* ## Brief change log - *Refactor tests to git rid of timeout of CompletableFuture assertions..* ## Verifying this change Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (100MB)* - *Extended integration test for recovery after master (JobManager) failure* - *Added test that validates that TaskInfo is transferred only once across recoveries* - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) - The serializers: (yes / no / don't know) - The runtime per-record code paths (performance sensitive): (yes / no / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) - The S3 file system connector: (yes / no / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
