reswqa commented on code in PR #22161:
URL: https://github.com/apache/flink/pull/22161#discussion_r1138321717
##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/FlinkCompletableFutureAssert.java:
##########
@@ -46,6 +48,9 @@
private static final String SHOULD_HAVE_FAILED = "%nExpecting%n <%s>%nto
have failed.%n";
+ private static final String SHOULD_NOT_COMPLETED =
+ "%nExpecting%n <%s>%nto have not completed normally or
exceptionally.%n";
+
Review Comment:
Good suggesstion.
##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/FlinkCompletableFutureAssert.java:
##########
@@ -46,6 +48,9 @@
private static final String SHOULD_HAVE_FAILED = "%nExpecting%n <%s>%nto
have failed.%n";
+ private static final String SHOULD_NOT_COMPLETED =
+ "%nExpecting%n <%s>%nto have not completed normally or
exceptionally.%n";
+
Review Comment:
Good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
