[
https://issues.apache.org/jira/browse/FLINK-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15580868#comment-15580868
]
ASF GitHub Bot commented on FLINK-3999:
---------------------------------------
GitHub user nssalian opened a pull request:
https://github.com/apache/flink/pull/2642
[FLINK-3999]: Rename the `running` flag in the drivers to `canceled`
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-3999]
Rename the `running` flag in the drivers to `canceled`")
- Added the cancelled flag instead of the running flag to replace the
functionality since it was not truly "running".
- Modified the operators to have the cancelled instead of running even in
tests
- [ ] Documentation
- Modified the Example for the Loading Data where the import statement
needed to be changed.
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
- Ran a Travis build and local mvn tests as well.
@ggevay if you could help review. Thank you.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/flink FLINK-3999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2642
----
commit 65b3ff78f100ed1b13ec2fcc727f4869823b5918
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-09-12T22:38:06Z
FLINK-4614: Changed the version from 1.2-SNAPSHOT to 1.2 to help correct
docs in 1.2.0
commit 2ef440161699943cb3cc38eccc6ef39a1bd512a1
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-10-16T20:41:00Z
FLINK-3999: Modified the running flag for the runtime module to cancelled
to depict correctness
commit 46d91b0052971e5116c674a350ff38aa692616bb
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-10-16T23:07:45Z
FLINK-3999: Fixed Tests
commit 1433a5db5ad13aef3f76e8ab4b2fa131272fe59d
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-10-16T23:58:33Z
FLINK-3999: More changes to fix tests
commit ba4f429043f3985db5ab37a3902a6fee15a7440e
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date: 2016-10-17T01:12:43Z
FLINK-3999: Updated config version
----
> Rename the `running` flag in the drivers to `canceled`
> ------------------------------------------------------
>
> Key: FLINK-3999
> URL: https://issues.apache.org/jira/browse/FLINK-3999
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
> Reporter: Gabor Gevay
> Assignee: Neelesh Srinivas Salian
> Priority: Trivial
>
> The name of the {{running}} flag in the drivers doesn't reflect its usage:
> when the operator just stops normally, then it is not running anymore, but
> the {{running}} flag will still be true, since the {{running}} flag is only
> set when cancelling.
> It should be renamed, and the value inverted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
