snuyanzin commented on code in PR #22175:
URL: https://github.com/apache/flink/pull/22175#discussion_r1137257533
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/UseModulesOperation.java:
##########
@@ -37,4 +41,16 @@ public List<String> getModuleNames() {
public String asSummaryString() {
return String.format("USE MODULES: %s", moduleNames);
}
+
Review Comment:
Not related to this PR,
however since this class is touched.
Doesn't it make sense to init `moduleNames` as unmodified collection once
and then return it rather than create a new unmodified list per getter call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
