wuchong commented on code in PR #22175: URL: https://github.com/apache/flink/pull/22175#discussion_r1138092220
########## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ExecutableOperation.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.operations; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.api.internal.TableEnvironmentImpl; +import org.apache.flink.table.api.internal.TableResultInternal; +import org.apache.flink.table.catalog.CatalogManager; +import org.apache.flink.table.module.ModuleManager; + +/** + * An {@link ExecutableOperation} represents an operation that is executed for its side effects. + * + * <p>This internal interface is proposed to reduce the maintenance of bloated {@link + * TableEnvironmentImpl#executeInternal(Operation)} and improve code readability as execution logic + * is co-located with the operation definition. Besides, this interface can be used to extend + * user-defined operation with customized execution logic once this interface is stable and public + * in the future. + */ +@Internal +public interface ExecutableOperation extends Operation { + + /** + * Executes the given operation and return the execution result. + * + * @param ctx the context to execute the operation. + * @return the content of the execution result. + * @see org.apache.flink.table.api.internal.TableEnvironmentInternal#executeInternal(Operation) + */ + TableResultInternal execute(Context ctx); + + /** + * The context to execute the operation. Operation may make side effect to the context, e.g. + * catalog manager, configuration. + */ + interface Context { + + CatalogManager getCatalogManager(); + + ModuleManager getModuleManager(); Review Comment: You are right. In my PoC, I have such members but removed in the PR. I was thinking to add them when needed. But I'm also fine to add all the required members at the beginning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
