echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1137367392
########## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/reader/CassandraQueryTest.java: ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.cassandra.source.reader; + +import org.apache.flink.connector.cassandra.source.CassandraSource; + +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +import static org.assertj.core.api.Assertions.assertThat; + +/** tests for query generation and query sanity checks. */ +class CassandraQueryTest { + + private static final Pattern SELECT_PATTERN = Pattern.compile(CassandraSource.SELECT_REGEXP); + + @Test + public void testKeySpaceTableExtractionRegexp() { + Arrays.asList( + "select field FROM keyspace.table where field = value;", + "select * FROM keyspace.table;", + "select field1, field2 from keyspace.table;", + "select field1, field2 from keyspace.table LIMIT(1000);", + "select field1 from keyspace.table ;", + "select field1 from keyspace.table where field1=1;") + .forEach(CassandraQueryTest::assertQueryFormatCorrect); + + Arrays.asList( + "select field1 from table;", // missing keyspace + "select field1 from keyspace.table" // missing ";" + ) Review Comment: yes but `;` is kind of optional (tolerance) depending on the client CQL tool that sent the request so it is a common mistake But fair enough for the corner case, I guess an excess of protection is not bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
